Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

We only wait 10s for an outbound /make_join to complete? #3013

Closed
ara4n opened this issue Mar 18, 2018 · 3 comments
Closed

We only wait 10s for an outbound /make_join to complete? #3013

ara4n opened this issue Mar 18, 2018 · 3 comments
Labels
A-Federated-Join joins over federation generally suck Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p2 (Deprecated Label)

Comments

@ara4n
Copy link
Member

ara4n commented Mar 18, 2018

This seems pretty low - a slowish HS could easily take a bit longer

@ara4n ara4n changed the title We only wait 10s for a /make_join to complete? We only wait 10s for an outbound /make_join to complete? Mar 18, 2018
@ara4n
Copy link
Member Author

ara4n commented Mar 18, 2018

It ends up looking like this:

2018-03-18 22:00:44,792 - synapse.access.http.9092 - 59 - INFO - POST-6704336 - 127.0.0.1 - 9092 - Received request: POST /_synapse/replication/remote_join
2018-03-18 22:00:44,793 - synapse.replication.http.membership - 202 - INFO - POST-6704336 - remote_join: @appservice-irc:matrix.org into room: !dCvArKOPaYSBGFWBKG:maunium.net
2018-03-18 22:00:44,793 - synapse.http.outbound - 165 - INFO - POST-6704336 - {GET-O-113336} [maunium.net] Sending request: GET matrix://maunium.net/_matrix/federation/v1/make_join/!dCvArKOPaYSBGFWBKG:maunium.net/@appservice-irc:matrix.org
2018-03-18 22:00:54,898 - synapse.http.matrixfederationclient - 223 - WARNING - POST-6704336 - {GET-O-113336} Sending request failed to maunium.net: GET matrix://maunium.net/_matrix/federation/v1/make_join/!dCvArKOPaYSBGFWBKG:maunium.net/@appservice-irc:matrix.org: TimeoutError('',)
2018-03-18 22:00:54,899 - synapse.http.outbound - 247 - INFO - POST-6704336 - {GET-O-113336} [maunium.net] Result: TimeoutError('',)
2018-03-18 22:00:54,899 - synapse.federation.federation_client - 533 - WARNING - POST-6704336 - Failed to make_join via maunium.net: 
2018-03-18 22:00:54,900 - synapse.http.server - 192 - ERROR - POST-6704336 - Failed handle request synapse.http.server._async_render on <synapse.replication.http.ReplicationRestResource object at 0x7f26f2579210>: <SynapseRequest at 0x7f25b8b40320 method=POST uri=/_synapse/replication/remote_join clientproto=HTTP/1.1 site=9092>: Traceback (most recent call last):
2018-03-18 22:00:54,901 - synapse.access.http.9092 - 93 - INFO - POST-6704336 - 127.0.0.1 - 9092 - {@appservice-irc:matrix.org} Processed request: 10108ms (0ms, 0ms) (0ms/0ms/0) 55B 500 "POST /_synapse/replication/remote_join HTTP/1.1" "Synapse/0.26.0 (b=matrix-org-hotfixes,411c437)"

@ara4n
Copy link
Member Author

ara4n commented Mar 18, 2018

Given that we retry normal federation-sends a whole bunch of times:

2018-03-18 22:03:06,137 - synapse.http.outbound - 165 - INFO - None - {PUT-O-2840195} [maunium.net] Sending request: PUT matrix://maunium.net/_matrix/federation/v1/send/1521297686231/
2018-03-18 22:03:17,379 - synapse.http.matrixfederationclient - 223 - WARNING - None - {PUT-O-2840195} Sending request failed to maunium.net: PUT matrix://maunium.net/_matrix/federation/v1/send/1521297686231/: TimeoutError('',)
2018-03-18 22:03:32,392 - synapse.http.matrixfederationclient - 223 - WARNING - None - {PUT-O-2840195} Sending request failed to maunium.net: PUT matrix://maunium.net/_matrix/federation/v1/send/1521297686231/: TimeoutError('',)
2018-03-18 22:03:47,713 - synapse.http.outbound - 247 - INFO - None - {PUT-O-2840195} [maunium.net] Result: 200 OK

this feels particularly mean.

@richvdh
Copy link
Member

richvdh commented Feb 27, 2019

it seems to be 20 seconds, and afaict has been ever since #733. I don't know where the 10s timeout came from, but empirically it's gone away.

@richvdh richvdh closed this as completed Feb 27, 2019
@MadLittleMods MadLittleMods added the A-Federated-Join joins over federation generally suck label Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Federated-Join joins over federation generally suck Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p2 (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

4 participants