This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fixup removal of duplicate user_ips rows
#4432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4432 +/- ##
==========================================
- Coverage 73.7% 73.7% -0.01%
==========================================
Files 300 300
Lines 29705 29705
Branches 4882 4882
==========================================
- Hits 21895 21894 -1
+ Misses 6385 6383 -2
- Partials 1425 1428 +3 |
erikjohnston
force-pushed
the
erikj/fixup_remove_old_user_ips
branch
2 times, most recently
from
7aac8fc to
1b3cc39
Compare
erikjohnston
force-pushed
the
erikj/fixup_remove_old_user_ips
branch
from
1b3cc39 to
6e05f9b
Compare
erikjohnston
force-pushed
the
erikj/fixup_remove_old_user_ips
branch
from
6e05f9b to
2f947b7
Compare
hawkowl
approved these changes
Jan 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a few changes that should hopefully make it a bit cleaner.
Now based on #4434