Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Make loopingcall wrapper log loudly if it gets killed. #3929

Closed
erikjohnston opened this issue Sep 21, 2018 · 1 comment
Closed

Make loopingcall wrapper log loudly if it gets killed. #3929

erikjohnston opened this issue Sep 21, 2018 · 1 comment
Labels
A-Logging Synapse's logs (structured or otherwise). Not metrics. z-bug (Deprecated Label) z-p2 (Deprecated Label)

Comments

@erikjohnston
Copy link
Member

If a looping call function errors, then it kills the loop entirely. Currently it throws away the exception logs, so we should make it actually log them.

Related to #3921
@erikjohnston erikjohnston added z-bug (Deprecated Label) A-Logging Synapse's logs (structured or otherwise). Not metrics. labels Sep 21, 2018
@erikjohnston erikjohnston mentioned this issue Sep 21, 2018
Closed
erikjohnston added a commit that referenced this issue Oct 5, 2018
@erikjohnston
Log looping call exceptions
f7199e8 
If a looping call function errors, then it kills the loop entirely.
Currently it throws away the exception logs, so we should make it
actually log them.

Fixes #3929
@erikjohnston erikjohnston mentioned this issue Oct 5, 2018
Merged
@neilisfragile neilisfragile added the z-p2 (Deprecated Label) label Oct 5, 2018
@erikjohnston
Copy link
Member Author

(Fixed in #4008)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Logging Synapse's logs (structured or otherwise). Not metrics. z-bug (Deprecated Label) z-p2 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neilisfragile @erikjohnston