This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add API for setting per user account data at the top level or room level. #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| PUT /user/{user_id}/account_data/{account_dataType} HTTP/1.1 | ||
| """ | ||
| PATTERN = client_v2_pattern( |
There was a problem hiding this comment.
As per spec comment, with is this v2_alpha not v1?
There was a problem hiding this comment.
Done - Spec has changed
|
LGTM modulo comments |
| @@ -0,0 +1,111 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
This file should no longer be in the v2_alpha directory
There was a problem hiding this comment.
Where should it be?
There was a problem hiding this comment.
Ignore me. I am being dumb.
NegativeMjark
force-pushed
the
markjh/client_config
branch
from
4b0f697 to
6e70979
Compare
NegativeMjark
force-pushed
the
markjh/client_config
branch
from
4b0f697 to
95f30ec
Compare
NegativeMjark
added a commit
that referenced
this pull request
Dec 1, 2015
Add API for setting per user account data at the top level or room level.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@NegativeMjark should squash merge this when he merges it because of foobar.
Implement the API added by matrix-org/matrix-spec-proposals#168
Tested by matrix-org/sytest#82