Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

extend tox testing for py3 to avoid regressions #3302

Merged
merged 1 commit into from
May 29, 2018

Conversation

krombel
Copy link
Contributor

@krombel krombel commented May 29, 2018

Just to avoid regressions regarding python 3 while doing further development.

This list is the current list of all succeeding tests.
It can be extended (or reduced to contain complete folders until we only have tests) while further development takes place.

Signed-Off-By: Matthias Kesler [email protected]

@matrixbot
Copy link
Member

Can one of the admins verify this patch?

1 similar comment
@matrixbot
Copy link
Member

Can one of the admins verify this patch?

@richvdh
Copy link
Member

richvdh commented May 29, 2018

@matrixbot: test this please

@richvdh richvdh merged commit db2e460 into matrix-org:develop May 29, 2018
@krombel krombel deleted the py3_extend_tox_testing branch May 29, 2018 17:05
@krombel
Copy link
Contributor Author

krombel commented May 29, 2018

Just as a note (e.g. for myself and for whoever want to update tox.ini in future):
I use the following script to find passing modules.
The output of the script

  • has to be adjusted from module-names to paths (e.g. tests.test_dns => tests/test_dns.py) and
  • can be enhanced by joining multiple modules by using a complete folder.
#!/bin/bash

[ -d .tox/py36 ] || echo "This script depends on tox to have created the py36 env" || exit 1
. .tox/py36/bin/activate

module_list=/tmp/synapse_py36_test_modules.txt
module_test=/tmp/synapse_py36_test_modules_test.txt
[ -f $module_list ] && rm $module_list
[ -f $module_test ] && rm $module_test

echo "run tests"
trial tests/ | while read line ; do
	if echo $line | grep "^tests" 1>/dev/null ; then
		module=$line
		echo $module >> $module_list;
		continue
	fi
	echo $module $line >> $module_test
done

# cleanup module_list
cat $module_list | sort | uniq > $module_list.2
mv $module_list.2 $module_list

cat $module_test | grep -E "ERROR|FAIL" | cut -d' ' -f 1 | while read line; do
	sed -i "/$line/d" $module_list
done

echo "Succeeding modules:"
cat $module_list

@richvdh
Copy link
Member

richvdh commented May 29, 2018

has to be adjusted from module-names to paths (e.g. tests.test_dns => tests/test_dns.py) and

Is this correct? I thought it would work with module names

@krombel
Copy link
Contributor Author

krombel commented May 29, 2018

I did what I said. The content after this transition you can see in tox.ini
I have not tested if module names would work there as well but my approach at least works

neilisfragile added a commit that referenced this pull request Jun 6, 2018
Changes in synapse v0.31.0 (2018-06-06)
======================================

Most notable change from v0.30.0 is to switch to python prometheus library to improve system
stats reporting. WARNING this changes a number of prometheus metrics in a
backwards-incompatible manner. For more details, see
`docs/metrics-howto.rst <docs/metrics-howto.rst#removal-of-deprecated-metrics--time-based-counters-becoming-histograms-in-0310>`_.

Bug Fixes:

* Fix metric documentation tables (PR #3341)
* Fix LaterGuage error handling (694968f)
* Fix replication metrics (b7e7fd2)

Changes in synapse v0.31.0-rc1 (2018-06-04)
==========================================

Features:

* Switch to the Python Prometheus library (PR #3256, #3274)
* Let users leave the server notice room after joining (PR #3287)

Changes:

* daily user type phone home stats (PR #3264)
* Use iter* methods for _filter_events_for_server (PR #3267)
* Docs on consent bits (PR #3268)
* Remove users from user directory on deactivate (PR #3277)
* Avoid sending consent notice to guest users (PR #3288)
* disable CPUMetrics if no /proc/self/stat (PR #3299)
* Add local and loopback IPv6 addresses to url_preview_ip_range_blacklist (PR #3312) Thanks to @thegcat!
* Consistently use six's iteritems and wrap lazy keys/values in list() if they're not meant to be lazy (PR #3307)
* Add private IPv6 addresses to example config for url preview blacklist (PR #3317) Thanks to @thegcat!
* Reduce stuck read-receipts: ignore depth when updating (PR #3318)
* Put python's logs into Trial when running unit tests (PR #3319)

Changes, python 3 migration:

* Replace some more comparisons with six (PR #3243) Thanks to @NotAFile!
* replace some iteritems with six (PR #3244) Thanks to @NotAFile!
* Add batch_iter to utils (PR #3245) Thanks to @NotAFile!
* use repr, not str (PR #3246) Thanks to @NotAFile!
* Misc Python3 fixes (PR #3247) Thanks to @NotAFile!
* Py3 storage/_base.py (PR #3278) Thanks to @NotAFile!
* more six iteritems (PR #3279) Thanks to @NotAFile!
* More Misc. py3 fixes (PR #3280) Thanks to @NotAFile!
* remaining isintance fixes (PR #3281) Thanks to @NotAFile!
* py3-ize state.py (PR #3283) Thanks to @NotAFile!
* extend tox testing for py3 to avoid regressions (PR #3302) Thanks to @krombel!
* use memoryview in py3 (PR #3303) Thanks to @NotAFile!

Bugs:

* Fix federation backfill bugs (PR #3261)
* federation: fix LaterGauge usage (PR #3328) Thanks to @intelfx!
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants