Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove ReplicationLayer and user Client/Server directly #2978

Merged
merged 8 commits into from
Mar 13, 2018

Conversation

erikjohnston
Copy link
Member

This removes the ReplicationLayer mixin

Includes #2976 and #2977

@erikjohnston
Copy link
Member Author

We might want to consider rename replication_client and replication_serve. Maybe federation_*?

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good otherwise

@@ -100,7 +101,8 @@ def build_DEPENDENCY(self)
DEPENDENCIES = [
'http_client',
'db_pool',
'replication_layer',
'replication_client',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it called replication client/server rather than federation client/server? I find the whole thing confusing.

@richvdh
Copy link
Member

richvdh commented Mar 13, 2018

We might want to consider rename replication_client and replication_serve. Maybe federation_*?

oh, yes. this.

@richvdh richvdh assigned erikjohnston and unassigned richvdh Mar 13, 2018
@erikjohnston erikjohnston assigned richvdh and unassigned erikjohnston Mar 13, 2018
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richvdh richvdh assigned erikjohnston and unassigned richvdh Mar 13, 2018
@erikjohnston erikjohnston merged commit 95cb401 into develop Mar 13, 2018
@erikjohnston erikjohnston deleted the erikj/refactor_replication_layer branch March 22, 2018 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants