Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Some User Directory use-cases seem flakey #2306

Closed
leonerd opened this issue Jun 26, 2017 · 1 comment
Closed

Some User Directory use-cases seem flakey #2306

leonerd opened this issue Jun 26, 2017 · 1 comment

Comments

@leonerd
Copy link
Contributor

leonerd commented Jun 26, 2017

At first this appeared to be a race condition in sytest, but I don't think it is.

There are a few integration tests that sometimes fail; e.g.

Running tests/52user-directory/01public.pl...
...
  Testing if: Users appear/disappear from directory when history_visibility are changed... 
   | User initially not in directory... OK
   | User appears in directory after history_visibility set to public... OK
   +--- FAIL:
 | Timed out waiting for test at ./run-tests.pl line 542.
 +----------------------
...

In current sytest/develop this appears to be a race when running it, because it's flaky and variously comes and goes, but adding a try_repeat_until_success loop to it just means it either succeeds quickly or times out and fails every attempt. So it feels more like it sometimes succeeds or fails within the synapse itself.
@turt2live turt2live mentioned this issue Oct 4, 2018
Closed
richvdh added a commit that referenced this issue Jul 8, 2019
@richvdh
Unblacklist some user_directory sytests
9773283 
Now that the userdir has been rewritten (#4537 etc), I reckon there's a good
chance of these tests working right. Let's find out.

Fixes #2306
@richvdh richvdh mentioned this issue Jul 8, 2019
Merged
@hawkowl
Copy link
Contributor

hawkowl commented Jul 8, 2019

Fixed by the rewrite in #4537 and removed from the blacklist in #5637.

@hawkowl hawkowl closed this as completed Jul 8, 2019
hawkowl pushed a commit that referenced this issue Jul 8, 2019
@richvdh @hawkowl
Unblacklist some user_directory sytests (#5637)
43d175d 
Fixes #2306
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leonerd @hawkowl