Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Drop obsolete tables from the DB, as they are incredibly confusing when doing ops work #1830

Closed
ara4n opened this issue Jan 19, 2017 · 4 comments
Closed

Drop obsolete tables from the DB, as they are incredibly confusing when doing ops work #1830

ara4n opened this issue Jan 19, 2017 · 4 comments
Assignees
@neilisfragile

Comments

@ara4n
Copy link
Member

ara4n commented Jan 19, 2017 •
edited
Loading

Starting with:

application_services
application_services_regex

I just spent a while trying to work out why they were blank, before inferring that they're not actually used?
@ara4n
Copy link
Member Author

ara4n commented Apr 2, 2019

also transaction_id_to_pdu

@neilisfragile neilisfragile self-assigned this Apr 2, 2019
@neilisfragile neilisfragile mentioned this issue Apr 2, 2019
Merged
@ara4n
Copy link
Member Author

ara4n commented Apr 2, 2019

and also

stats_reporting
current_state_resets
event_content_hashes
event_destinations
event_edge_hashes
event_signatures
feedback
room_hosts
state_forward_extremities

(probably wise to double-check these one by one, but I have gone through them one by one)

@ara4n
Copy link
Member Author

ara4n commented Apr 2, 2019 •
edited
Loading

Possibly also room_names and topics - i can't see anything that reads from them, and I'd assume #4338 might obsolete them?

@ara4n ara4n changed the title If the application_services and application_services_regex table are no longer in use, please can we drop them? Drop obsolete tables from the DB, as they are incredibly confusing when doing ops work Apr 2, 2019
neilisfragile added a commit that referenced this issue Apr 8, 2019
@neilisfragile
drop tables listed in #1830 (#4992)
2d95168 
Tables dropped: 
 * application_services, 
 * application_services_regex, 
 * transaction_id_to_pdu, 
 * stats_reporting
 * current_state_resets
 * event_content_hashes
 * event_destinations
 * event_edge_hashes
 * event_signatures
 * feedback
 * room_hosts
 * state_forward_extremities
@neilisfragile
Copy link
Contributor

Mostly fixed in #4992 with the exception of room_names and topics - but only because there is an active PR in this area (#4338), so seemed best (albeit conservatively) not to touch them.

I'll create a new issue for room_names and topics

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@neilisfragile neilisfragile

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neilisfragile @ara4n