Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

'dynamic_thumbnails' ignores aspect when scaling #1677

Closed
dbkr opened this issue Dec 6, 2016 · 1 comment
Closed

'dynamic_thumbnails' ignores aspect when scaling #1677

dbkr opened this issue Dec 6, 2016 · 1 comment

Comments

@dbkr
Copy link
Member

dbkr commented Dec 6, 2016

Turning on the 'dynamic_thumbnails' option on synapse results in images you see in the riot web client being scaled to the exact dimensions given in the URL query rather than the dimensions acting as a bounding box and aspect-scaling. This makes images look very silly.
@dbkr dbkr mentioned this issue Dec 6, 2016
Closed
jkolo added a commit to jkolo/synapse that referenced this issue Jan 16, 2017
@jkolo
Fix matrix-org#1677 and change unique on local_media_repository_thumb…
d263a32 
…nails and remote_media_cache_thumbnails
@jkolo jkolo mentioned this issue Jan 16, 2017
Closed
@dbkr dbkr mentioned this issue Feb 16, 2017
Closed
@lukebarnard1
Copy link
Contributor

There is a PR for the above commit: #1816

erikjohnston added a commit that referenced this issue Feb 27, 2017
@erikjohnston
Merge pull request #1945 from jkolo/fix_dynamic_thumbnails_aspect
acf6d4d 
Fix #1677 (dynamic thumbnails aspect)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbkr @lukebarnard1