Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Metrics for MSC3861 token introspection #16119

Closed
hughns opened this issue Aug 16, 2023 · 2 comments
Closed

Metrics for MSC3861 token introspection #16119

hughns opened this issue Aug 16, 2023 · 2 comments
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@hughns
Copy link
Member

hughns commented Aug 16, 2023

Off the back of #16087 and given the dependency between Synapse and a MSC3861 OpenID Provider on an ongoing basis, it probably makes sense to expose metrics for:

  • number of introspection requests
  • response time
  • cache hit/miss rates
@reivilibre reivilibre added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Aug 17, 2023
@sandhose
Copy link
Member

I would implement this as an histogram around the synapse.api.msc3861_delegated.MSC3861Delegated#_introspect_token method.
It should have labels to distinguish at least those states:

  • cache hit
  • cache miss, but non-2xx status code
  • cache miss, and introspection call succeeded

@erikjohnston
Copy link
Member

Have added a response time histogram in #16131, which is labeled by response code (matching other such histograms).

We should already have cache hit/miss counter metrics by default, so I don't think we need any thing else there

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

No branches or pull requests

5 participants