This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Synapse selects "preset": "public_chat" by default, while it should be "private_chat"
#11498
Labels
A-Spec-Compliance
places where synapse does not conform to the spec
S-Tolerable
Minor significance, cosmetic issues, low or no impact to users.
T-Defect
Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Comments
ShadowJonathan
added a commit
to ShadowJonathan/complement
that referenced
this issue
Dec 2, 2021
squahtx
added
S-Tolerable
kegsay
pushed a commit
to matrix-org/complement
that referenced
this issue
Jan 6, 2022
* improve existing alias tests * add tests * rearrange test * fix test failures * fix synapse public_chat weirdness matrix-org/synapse#11498
reivilibre
added
the
A-Spec-Compliance
|
Even our test helpers say it should be private by default (of course the tests in practice rely on them being public): is_public: If True, the `visibility` parameter will be set to
"public". If False, it will be set to "private". If left
unspecified, the server will set it to an appropriate default
(which should be "private" as per the CS spec). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
I noticed this while looking at the spec;
While creating rooms,
/createRoomsrecommends - for a default"preset"- to use"private_chat", recommending it to look at"visibility", which defaults to"private".However, synapse creates
public_chatrooms when given no options.I know that the spec is only saying "should" here, but since Dendrite and Conduit also display this behaviour, it could cause confusion that a "known good" server such as Synapse is going against spec here, creating bugs in software where previously there were none.
Version information
Version: v1.48.0
Install method: Docker
Platform: Linux
The text was updated successfully, but these errors were encountered: