Remove duplicate session check in web fallback servlet (#6702)

matrix-org · Jan 15, 2020 · edc244e · edc244e
1 parent 608bf7d
commit edc244e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/changelog.d/6702.misc b/changelog.d/6702.misc
@@ -0,0 +1 @@
+Remove duplicate check for the `session` query parameter on the `/auth/xxx/fallback/web` Client-Server endpoint.
diff --git a/synapse/rest/client/v2_alpha/auth.py b/synapse/rest/client/v2_alpha/auth.py
@@ -206,10 +206,6 @@ async def on_POST(self, request, stagetype):
 
             return None
         elif stagetype == LoginType.TERMS:
-            if ("session" not in request.args or len(request.args["session"])) == 0:
-                raise SynapseError(400, "No session supplied")
-
-            session = request.args["session"][0]
             authdict = {"session": session}
 
             success = await self.auth_handler.add_oob_auth(
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Remove duplicate check for the `session` query parameter on the `/auth/xxx/fallback/web` Client-Server endpoint.