Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Add some more comments appservice user registration
Browse files Browse the repository at this point in the history
Explain why we don't validate userids registered via app services
  • Loading branch information
richvdh committed Nov 10, 2017
1 parent e0ebd1e commit e508145
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion synapse/rest/client/v2_alpha/register.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,10 @@ def on_POST(self, request):
# fallback to 'username' if they gave one.
desired_username = body.get("user", desired_username)

# XXX we should check that desired_username is valid
# XXX we should check that desired_username is valid. Currently
# we give appservices carte blanche for any insanity in mxids,
# because the IRC bridges rely on being able to register stupid
# IDs.

access_token = get_access_token_from_request(request)

Expand Down

0 comments on commit e508145

Please sign in to comment.