Strip trailing / from server_url in register_new_matrix_user

When server URL provided to register_new_matrix_user includes path component (e.g. "http://localhost:8008/"), the command fails with "ERROR! Received 400 Bad Request". Stripping trailing slash from the server_url command argument makes sure combined endpoint URL remains valid.
matrix-org · Nov 25, 2020 · ddb1464 · ddb1464
1 parent 3f0ff53
commit ddb1464
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/8823.bugfix b/changelog.d/8823.bugfix
@@ -0,0 +1 @@
+Fix register_new_matrix_user failing with Bad Request when trailing slash is included in server URL.
diff --git a/synapse/_scripts/register_new_matrix_user.py b/synapse/_scripts/register_new_matrix_user.py
@@ -37,7 +37,7 @@ def request_registration(
     exit=sys.exit,
 ):
 
-    url = "%s/_synapse/admin/v1/register" % (server_location,)
+    url = "%s/_synapse/admin/v1/register" % (server_location.rstrip("/"),)
 
     # Get the nonce
     r = requests.get(url, verify=False)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix register_new_matrix_user failing with Bad Request when trailing slash is included in server URL.