Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Fix TODO comment regarding E2E AS reliability (catch-up)
Browse files Browse the repository at this point in the history
  • Loading branch information
reivilibre committed Feb 11, 2022
1 parent 853b29b commit c696a03
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions synapse/storage/databases/main/appservice.py
Original file line number Diff line number Diff line change
Expand Up @@ -359,8 +359,9 @@ def _get_oldest_unsent_txn(txn):

events = await self.get_events_as_list(event_ids)

# TODO: should we recalculate one-time key counts and unused fallback
# key counts here?
# TODO: to-device messages, one-time key counts and unused fallback keys
# are not yet populated for catch-up transactions.
# We likely want to populate those for reliability.
return AppServiceTransaction(
service=service,
id=entry["txn_id"],
Expand Down

0 comments on commit c696a03

Please sign in to comment.