Bump types-psycopg2 from 2.9.21.11 to 2.9.21.14 (#16381)

* Bump types-psycopg2 from 2.9.21.11 to 2.9.21.14 Bumps [types-psycopg2](https://github.com/python/typeshed) from 2.9.21.11 to 2.9.21.14. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-psycopg2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Relax the annotation of Cursor.description See #16343 (comment) for rationale. * Changelog * Changelog --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Robertson <[email protected]>
matrix-org · Sep 25, 2023 · b225acf · b225acf
1 parent 139a24d
commit b225acf
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 32 deletions.
diff --git a/changelog.d/16381.misc b/changelog.d/16381.misc
@@ -0,0 +1 @@
+Improve type hints, and bump types-psycopg2 from 2.9.21.11 to 2.9.21.14.
diff --git a/poetry.lock b/poetry.lock
diff --git a/synapse/storage/database.py b/synapse/storage/database.py
@@ -361,19 +361,7 @@ def rowcount(self) -> int:
     @property
     def description(
         self,
-    ) -> Optional[
-        Sequence[
-            Tuple[
-                str,
-                Optional[Any],
-                Optional[int],
-                Optional[int],
-                Optional[int],
-                Optional[int],
-                Optional[int],
-            ]
-        ]
-    ]:
+    ) -> Optional[Sequence[Any]]:
         return self.txn.description
 
     def execute_batch(self, sql: str, args: Iterable[Iterable[Any]]) -> None:

diff --git a/synapse/storage/types.py b/synapse/storage/types.py
@@ -53,22 +53,10 @@ def fetchall(self) -> List[Tuple]:
     @property
     def description(
         self,
-    ) -> Optional[
-        Sequence[
-            # Note that this is an approximate typing based on sqlite3 and other
-            # drivers, and may not be entirely accurate.
-            # FWIW, the DBAPI 2 spec is: https://peps.python.org/pep-0249/#description
-            Tuple[
-                str,
-                Optional[Any],
-                Optional[int],
-                Optional[int],
-                Optional[int],
-                Optional[int],
-                Optional[int],
-            ]
-        ]
-    ]:
+    ) -> Optional[Sequence[Any]]:
+        # At the time of writing, Synapse only assumes that `column[0]: str` for each
+        # `column in description`. Since this is hard to express in the type system, and
+        # as this is rarely used in Synapse, we deem `column: Any` good enough.
         ...
 
     @property
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Improve type hints, and bump types-psycopg2 from 2.9.21.11 to 2.9.21.14.