Merge pull request #1650 from matrix-org/erikj/respect_ratelimited

Correctly handle 500's and 429 on federation

synapse/federation/transaction_queue.py

@@ -462,6 +462,13 @@ def json_data_cb():
                     code = e.code
                     response = e.response
 
+                    if e.code == 429 or 500 <= e.code:
+                        logger.info(
+                            "TX [%s] {%s} got %d response",
+                            destination, txn_id, code
+                        )
+                        raise e
+
                 logger.info(
                     "TX [%s] {%s} got %d response",
                     destination, txn_id, code

synapse/util/retryutils.py

@@ -123,7 +123,7 @@ def __enter__(self):
     def __exit__(self, exc_type, exc_val, exc_tb):
         valid_err_code = False
         if exc_type is not None and issubclass(exc_type, CodeMessageException):
-            valid_err_code = 0 <= exc_val.code < 500
+            valid_err_code = exc_val.code != 429 and 0 <= exc_val.code < 500
 
         if exc_type is None or valid_err_code:
             # We connected successfully.