Fix possible variable shadow in create_new_client_event (#14575)

matrix-org · Nov 29, 2022 · 72f3e38 · 72f3e38
1 parent 9ccc09f
commit 72f3e38
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/changelog.d/14575.misc b/changelog.d/14575.misc
@@ -0,0 +1 @@
+Fix a possible variable shadow in `create_new_client_event`.
diff --git a/synapse/handlers/message.py b/synapse/handlers/message.py
@@ -1135,11 +1135,13 @@ async def create_new_client_event(
             )
             state_events = await self.store.get_events_as_list(state_event_ids)
             # Create a StateMap[str]
-            state_map = {(e.type, e.state_key): e.event_id for e in state_events}
+            current_state_ids = {
+                (e.type, e.state_key): e.event_id for e in state_events
+            }
             # Actually strip down and only use the necessary auth events
             auth_event_ids = self._event_auth_handler.compute_auth_events(
                 event=temp_event,
-                current_state_ids=state_map,
+                current_state_ids=current_state_ids,
                 for_verification=False,
             )
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix a possible variable shadow in `create_new_client_event`.