Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
better commenting.
Browse files Browse the repository at this point in the history
btw, it looks like this never particularly deliberately special-cased non-utf8;
when Mjark added utf8 support in #259 he just left the original code path alone, assuming it worked.
  • Loading branch information
ara4n committed Apr 1, 2017
1 parent d833855 commit 70c8861
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion synapse/rest/media/v1/_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def respond_with_file(request, media_type, file_path,
if upload_name:
# technically we should only use the crazy *=utf-8'' syntax
# if the filename actually contains utf-8. but if we don't, some
# browsers (Chrome at some point before 57, and Firefox 52) get it
# browsers (Firefox 52, Safari 10, Chrome at some point < 57) get it
# get it wrong and return %20 verbatim rather than url-decoding it
# causing bug https://github.com/vector-im/riot-web/issues/3155
request.setHeader(
Expand Down

0 comments on commit 70c8861

Please sign in to comment.