Merge pull request #3554 from matrix-org/erikj/response_metrics_code

Add response code to response timer metrics
matrix-org · Jul 19, 2018 · 6f62a6e · 6f62a6e
2 parents 77091d7 + 5bd0a47
commit 6f62a6e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/changelog.d/3554.feature b/changelog.d/3554.feature
@@ -0,0 +1 @@
+Add `code` label to `synapse_http_server_response_time_seconds` prometheus metric
diff --git a/synapse/http/request_metrics.py b/synapse/http/request_metrics.py
@@ -38,7 +38,8 @@
 )
 
 response_timer = Histogram(
-    "synapse_http_server_response_time_seconds", "sec", ["method", "servlet", "tag"]
+    "synapse_http_server_response_time_seconds", "sec",
+    ["method", "servlet", "tag", "code"],
 )
 
 response_ru_utime = Counter(
@@ -171,11 +172,13 @@ def stop(self, time_sec, request):
                 )
                 return
 
-        outgoing_responses_counter.labels(request.method, str(request.code)).inc()
+        response_code = str(request.code)
+
+        outgoing_responses_counter.labels(request.method, response_code).inc()
 
         response_count.labels(request.method, self.name, tag).inc()
 
-        response_timer.labels(request.method, self.name, tag).observe(
+        response_timer.labels(request.method, self.name, tag, response_code).observe(
             time_sec - self.start
         )
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Add `code` label to `synapse_http_server_response_time_seconds` prometheus metric