Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Merge pull request #667 from matrix-org/dbkr/never_notify_member_events
Browse files Browse the repository at this point in the history
Never notify for member events.
  • Loading branch information
dbkr committed Mar 24, 2016
2 parents 647b041 + 3b554bd commit 31e6f86
Showing 1 changed file with 21 additions and 20 deletions.
41 changes: 21 additions & 20 deletions synapse/push/baserules.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,27 @@ def make_base_prepend_rules(kind, modified_base_rules):
'actions': [
'dont_notify',
]
}
},
# Will we sometimes want to know about people joining and leaving?
# Perhaps: if so, this could be expanded upon. Seems the most usual case
# is that we don't though. We add this override rule so that even if
# the room rule is set to notify, we don't get notifications about
# join/leave/avatar/displayname events.
# See also: https://matrix.org/jira/browse/SYN-607
{
'rule_id': 'global/override/.m.rule.member_event',
'conditions': [
{
'kind': 'event_match',
'key': 'type',
'pattern': 'm.room.member',
'_id': '_member',
}
],
'actions': [
'dont_notify'
]
},
]


Expand Down Expand Up @@ -261,25 +281,6 @@ def make_base_prepend_rules(kind, modified_base_rules):
}
]
},
# This is too simple: https://matrix.org/jira/browse/SYN-607
# Removing for now
# {
# 'rule_id': 'global/underride/.m.rule.member_event',
# 'conditions': [
# {
# 'kind': 'event_match',
# 'key': 'type',
# 'pattern': 'm.room.member',
# '_id': '_member',
# }
# ],
# 'actions': [
# 'notify', {
# 'set_tweak': 'highlight',
# 'value': False
# }
# ]
# },
{
'rule_id': 'global/underride/.m.rule.message',
'conditions': [
Expand Down

0 comments on commit 31e6f86

Please sign in to comment.