Remove the unused /pull federation API (#4118)

matrix-org · Oct 30, 2018 · 2e223a8 · 2e223a8
1 parent 0794504
commit 2e223a8
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 14 deletions.
diff --git a/changelog.d/4118.removal b/changelog.d/4118.removal
@@ -0,0 +1 @@
+The obsolete and non-functional /pull federation endpoint has been removed.
diff --git a/synapse/federation/federation_server.py b/synapse/federation/federation_server.py
@@ -323,11 +323,6 @@ def on_pdu_request(self, origin, event_id):
         else:
             defer.returnValue((404, ""))
 
-    @defer.inlineCallbacks
-    @log_function
-    def on_pull_request(self, origin, versions):
-        raise NotImplementedError("Pull transactions not implemented")
-
     @defer.inlineCallbacks
     def on_query_request(self, query_type, args):
         received_queries_counter.labels(query_type).inc()

diff --git a/synapse/federation/transport/server.py b/synapse/federation/transport/server.py
@@ -362,14 +362,6 @@ def on_PUT(self, origin, content, query, transaction_id):
         defer.returnValue((code, response))
 
 
-class FederationPullServlet(BaseFederationServlet):
-    PATH = "/pull/"
-
-    # This is for when someone asks us for everything since version X
-    def on_GET(self, origin, content, query):
-        return self.handler.on_pull_request(query["origin"][0], query["v"])
-
-
 class FederationEventServlet(BaseFederationServlet):
     PATH = "/event/(?P<event_id>[^/]*)/"
 
@@ -1261,7 +1253,6 @@ def on_PUT(self, origin, content, query, group_id):
 
 FEDERATION_SERVLET_CLASSES = (
     FederationSendServlet,
-    FederationPullServlet,
     FederationEventServlet,
     FederationStateServlet,
     FederationStateIdsServlet,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		The obsolete and non-functional /pull federation endpoint has been removed.