Correctly register shutdown handler for presence workers (#11518)

Fixes #11517
matrix-org · Dec 7, 2021 · 2a3ec6f · 2a3ec6f
1 parent eccc49d
commit 2a3ec6f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/11518.bugfix b/changelog.d/11518.bugfix
@@ -0,0 +1 @@
+Fix a regression in Synapse 1.48.0 where presence workers would not clear their presence updates over replication on shutdown.
diff --git a/synapse/handlers/presence.py b/synapse/handlers/presence.py
@@ -421,7 +421,7 @@ def __init__(self, hs: "HomeServer"):
             self._on_shutdown,
         )
 
-    def _on_shutdown(self) -> None:
+    async def _on_shutdown(self) -> None:
         if self._presence_enabled:
             self.hs.get_tcp_replication().send_command(
                 ClearUserSyncsCommand(self.instance_id)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix a regression in Synapse 1.48.0 where presence workers would not clear their presence updates over replication on shutdown.