Merge pull request #2637 from spantaleev/avoid-noop-media-deletes

Avoid no-op media deletes

synapse/storage/media_repository.py

@@ -254,6 +254,9 @@ def _get_expired_url_cache_txn(txn):
         return self.runInteraction("get_expired_url_cache", _get_expired_url_cache_txn)
 
     def delete_url_cache(self, media_ids):
+        if len(media_ids) == 0:
+            return
+
         sql = (
             "DELETE FROM local_media_repository_url_cache"
             " WHERE media_id = ?"
@@ -281,6 +284,9 @@ def _get_url_cache_media_before_txn(txn):
         )
 
     def delete_url_cache_media(self, media_ids):
+        if len(media_ids) == 0:
+            return
+
         def _delete_url_cache_media_txn(txn):
             sql = (
                 "DELETE FROM local_media_repository"