This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Don't push if an user account has expired #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMaul
force-pushed
the
mv/no-push-validity
branch
from
91bfee4 to
d05a48a
Compare
anoadragon453
approved these changes
Aug 28, 2020
MatMaul
force-pushed
the
mv/no-push-validity
branch
3 times, most recently
from
184f9cd to
88bef9c
Compare
MatMaul
force-pushed
the
mv/no-push-validity
branch
from
88bef9c to
5263d42
Compare
anoadragon453
suggested changes
Sep 18, 2020
synapse/handlers/account_validity.py
Outdated
|
|
||
|
|
||
| @defer.inlineCallbacks | ||
| def is_account_expired(user_id: str, store, current_ts: int): |
There was a problem hiding this comment.
We generally try not to pass the store around between functions, but instead always reference it from the homeserver object.
However, I think it would make more sense if this method were moved next to get_expiration_ts_for_user in synapse/storage/data_stores/main/registration.py. Then you could simply do yield store.is_account_expired(...), rather than having to import is_account_expired everywhere you want to use it.
anoadragon453
approved these changes
Sep 18, 2020
anoadragon453
added a commit
that referenced
this pull request
Oct 9, 2020
…oa/freeze_rooms * 'dinsic' of github.com:matrix-org/synapse-dinsic: Only assert valid next_link params when provided (#65) Don't push if an user account has expired (#58) Swap method calls in RoomAccessTestCase.test_change_rules (#64) Make all rooms noisy by default (#60) Make AccessRules use the public rooms directory instead of checking a room's join rules on rule change (#63) Override the power levels defaults, enforce mod requirement for invites, admin requirements for unknown state events (#61) RoomAccessRules cleanup (#62) Add a config option for validating 'next_link' parameters against a domain whitelist (#8275)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.