First cut of the module #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babolivier
added
the
Z-Time-Tracked
clokep
reviewed
Feb 2, 2022
clokep
approved these changes
Feb 3, 2022
Co-authored-by: Patrick Cloke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First cut of a module to check whether 3pids can be registered against a homeserver based on the response from a custom endpoint. This is happening in the context of the Tchap Synapse mainlining, and is mostly a copy of https://github.com/matrix-org/synapse-dinsic/blob/dinsic/synapse/util/threepids.py#L47-L71
CI is expected to fail since matrix-org/synapse#11854 and matrix-org/synapse#11868 haven't been released in a stable version of Synapse yet. I have ran the tests locally against a branch of Synapse that includes both of these changes, and they're passing.