Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a .tar.gz bundle loader #8

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Add a .tar.gz bundle loader #8

merged 2 commits into from
Jun 28, 2022

Conversation

sandhose
Copy link
Member

This adds an (optional) .tar.gz bundle loader, exposed in the library behind the loader feature. It's a fully async one, and only loads what's needed from the tar.

It also adds that capability to the CLI, by adding a --bundle flag. I also went ahead and changed the PathBufs in the CLI to camino's Utf8PathBuf, because it's a mess to have to deal with OsStrings, and not worth it.

@jondot: You might want to take a look to use that in the integration tests

@sandhose sandhose mentioned this pull request Jun 28, 2022
8 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2022

Codecov Report

Merging #8 (119f100) into main (e48e51e) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main      #8      +/-   ##
========================================
- Coverage   2.42%   2.36%   -0.06%     
========================================
  Files         30      31       +1     
  Lines       1443    1478      +35     
========================================
  Hits          35      35              
- Misses      1408    1443      +35     
Impacted Files Coverage Δ
src/bin/opa-eval.rs 1.51% <0.00%> (-0.10%) ⬇️
src/bin/simple.rs 5.26% <ø> (ø)
src/builtins/impls/base64url.rs 0.00% <ø> (ø)
src/builtins/impls/crypto.rs 0.00% <ø> (ø)
src/builtins/impls/glob.rs 0.00% <ø> (ø)
src/builtins/impls/graph.rs 0.00% <ø> (ø)
src/builtins/impls/graphql.rs 0.00% <ø> (ø)
src/builtins/impls/hex.rs 0.00% <ø> (ø)
src/builtins/impls/http.rs 0.00% <ø> (ø)
src/builtins/impls/io.rs 0.00% <ø> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b08c3ab...119f100. Read the comment docs.

@sandhose sandhose merged commit 611d778 into main Jun 28, 2022
@sandhose sandhose deleted the quenting/loader branch August 3, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants