Small improvements to make installation easier #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jannisteunissen
commented
May 1, 2019
jannisteunissen
commented
- Makefile: check whether pkg-config failed
- README.md: add instructions for MATRIX_NO_E2E, update required libs, how to install as non-root
Before, if one of the packages was not found, CFLAGS was not updated, which led to unexpected error messages.
richvdh
reviewed
May 9, 2019
|
Thanks for the suggestions, I'm not that familiar with Github's pull request interface, but I guess they are now corrected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.