Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch ACL updates #203

Closed
babolivier opened this issue Jan 27, 2022 · 1 comment · Fixed by #221
Closed

Batch ACL updates #203

babolivier opened this issue Jan 27, 2022 · 1 comment · Fixed by #221
Assignees
@Gnuxie

Comments

@babolivier
Copy link

babolivier commented Jan 27, 2022 •
edited
Loading

Mjolnir doesn't batch ACL updates, which means that it sends each new rule as a separate event. This is quite inconvenient when there are many updates to send at once (more than 70 today) and some of the rooms are high SNR ones (such as the Synapse announcements room) where it wouldn't be unrealistic to expect most members to have notifications set to "All messages" (since ACL changes generate notifications, see element-hq/element-web#20788).
@Yoric
Copy link
Contributor

Yoric commented Feb 1, 2022

Doesn't seem too difficult to implement. I think Mjölnir is due some maintenance on ACLs anyway, so we could introduce an ACL batch event.

@Gnuxie Gnuxie self-assigned this Feb 7, 2022
Gnuxie added a commit that referenced this issue Feb 10, 2022
@Gnuxie
Batch events from sync within BanList.
35d6c12 
Fixes #203
Gnuxie added a commit that referenced this issue Feb 10, 2022
@Gnuxie
Batch events from sync within BanList.
f229716 
Fixes #203
@Gnuxie Gnuxie mentioned this issue Feb 10, 2022
Merged
Gnuxie added a commit that referenced this issue Feb 15, 2022
@Gnuxie
Batch events from ban lists together during sync (#221)
e9dff8f 
* Test for batching ACL.

* Batch events from sync within BanList.

* Introduce the BanList.batch event to the BanList emitter to let Mjolnir sync after new events have been added from sync.

Fixes #203
Yoric pushed a commit that referenced this issue Feb 15, 2022
@Gnuxie @Yoric
Batch events from ban lists together during sync (#221)
0ff2364 
* Test for batching ACL.

* Batch events from sync within BanList.

* Introduce the BanList.batch event to the BanList emitter to let Mjolnir sync after new events have been added from sync.

Fixes #203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gnuxie Gnuxie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Batch events from ban lists together during sync matrix-org/mjolnir
3 participants
@Yoric @babolivier @Gnuxie