Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Link to SDKs from the "Build on Matrix" section #2548

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SjxSubham
Copy link
Contributor

Issue #2532

Review the changes, and let me know is this accurate position to add the link? Or should I Add at another line and tell me that exact position

Copy link
Collaborator

@MTRNord MTRNord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi :) The links end up without the /content part which is in the repository. Therefor that can be removed. Also there is an overview page at /ecosystem so we can drop the sdk. Additionally the docs links does redirect by default and it is slightly better to link tot he correct thing. If you can fix these then we can apply this :)

templates/index.html Outdated Show resolved Hide resolved
templates/index.html Outdated Show resolved Hide resolved
@SjxSubham SjxSubham requested a review from MTRNord November 7, 2024 16:06
@SjxSubham
Copy link
Contributor Author

@MTRNord Check the resolved changes... and let me know if any more changes are needed...

Copy link
Contributor

@thibaultamartin thibaultamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't rely on style attributes directly in the html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants