Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Add support to custom placeholder color #95

Closed
wants to merge 1 commit into from

Conversation

alfogrillo
Copy link
Contributor

No description provided.

@alfogrillo alfogrillo requested a review from a team September 14, 2023 15:09
Copy link
Contributor

@jonnyandrew jonnyandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this repository is just for hosting iOS releases and we don't make any manual changes. I think you'll need to make the changes in the core repo (matrix-org/matrix-rich-text-editor) and then make a release which will propogate the changes to this repository.

Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except if it's not the correct repository (see @jonnyandrew comment).

@alfogrillo
Copy link
Contributor Author

I think this repository is just for hosting iOS releases and we don't make any manual changes. I think you'll need to make the changes in the core repo (matrix-org/matrix-rich-text-editor) and then make a release which will propogate the changes to this repository.

Right. 😅
Opening the pr in the right repo soon!

@alfogrillo alfogrillo closed this Sep 14, 2023
@alfogrillo alfogrillo deleted the alfogrillo/add-placeholder-color branch September 15, 2023 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants