-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push notification rules should make sure to skip reply part of message #680
Comments
this is somewhat of a divided topic ftr - some people actually want this. We'd almost certainly have to make it a push rule or whatever the equivalent is post-notifications rework. |
Just wanting to crosspost my comment here: matrix-org/synapse#6202 (comment) I'm in favor of stripping the fallback before running the push rules against the message body. |
worth mentioning here that the problem applies to |
FWIW I'm currently relying on the fact that the reply fallback includes the MXID of the user being replied to for push notifications. Any plan to strip the fallback when evaluating push rules should probably also keep this in consideration. |
ATM it's not specified and synapse sends notifications If someone was tagged inside message, that's being replied.
Example:
At the screenshot both messages tagged me, when only first should.
This is part of this related issue:
element-hq/element-web#14943
Another part is matrix-org/matrix-spec-proposals#2735
The text was updated successfully, but these errors were encountered: