Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Replying to a message containing "@room" trigger noisy notification #8143

Closed
bmarty opened this issue Aug 21, 2020 · 3 comments
Closed

Replying to a message containing "@room" trigger noisy notification #8143

bmarty opened this issue Aug 21, 2020 · 3 comments

Comments

@bmarty
Copy link

bmarty commented Aug 21, 2020

Steps:

  • A message containing "@room" is sent to a room
  • A moderator reply to this message

Current behaviour:

  • the moderator reply triggers a highlight notification because the message contains "@room" (from the previous message)

Expected behaviour:

  • the highlight notification should only occurs if "@room" is in the reply itself
@auscompgeek
Copy link
Contributor

Related: element-hq/element-web#7874

@lieuwex
Copy link

lieuwex commented Aug 22, 2020

dup: #6202
related: https://github.com/matrix-org/matrix-doc/issues/2736

Again, just stripping the fallback before applying the push rules would fix this. If combined with matrix-org/matrix-spec-proposals#2463 it should fix most (if not all) unwanted highlight problems.

@richvdh
Copy link
Member

richvdh commented Aug 26, 2020

as @lieuwex says, this is a dup of #6202 and an artifact of matrix-org/matrix-doc#2736. I don't think there's anything to be done on the synapse side for now: it's something we can look to sort out as part of the notifcations rework

@richvdh richvdh closed this as completed Aug 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants