Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anchor tag name attribute is deprectated #1790

Closed
HarHarLinks opened this issue Apr 16, 2024 · 2 comments · Fixed by #1870
Closed

anchor tag name attribute is deprectated #1790

HarHarLinks opened this issue Apr 16, 2024 · 2 comments · Fixed by #1870
Labels
spec-bug Something which is in the spec, but is wrong

Comments

@HarHarLinks
Copy link
Contributor

HarHarLinks commented Apr 16, 2024 •
edited
Loading

Link to problem area:
https://spec.matrix.org/latest/client-server-api/#mroommessage-msgtypes

Issue
anchor tag name attribute is deprectated

Expected behaviour
should be replaced by the global title id attribute or removed
@HarHarLinks HarHarLinks added the spec-bug Something which is in the spec, but is wrong label Apr 16, 2024
@zecakeh
Copy link
Contributor

zecakeh commented Apr 25, 2024

MDN actually says to replace it with id, not title.

Given that the use case for this attribute is to be able to use the anchor as a link's target, I am wondering what is its intended use case for Matrix messages in the first place, since URLs in href are not permitted to be relative.

In my opinion it should just be removed.

@HarHarLinks
Copy link
Contributor Author

indeed, thanks, edited in OP

Johennes added a commit to Johennes/matrix-spec that referenced this issue Jun 14, 2024
@Johennes
Remove the deprecated name attribute on HTML anchor elements
b1c3c0d 
Fixes: matrix-org#1790
Signed-off-by: Johannes Marbach <[email protected]>
This was referenced Jun 14, 2024
Merged
Merged
uhoreg added a commit that referenced this issue Jul 10, 2024
@Johennes @turt2live @uhoreg
Remove the deprecated name attribute on HTML anchor elements (#1870)
b1349dd 
* Remove the deprecated name attribute on HTML anchor elements

Fixes: #1790
Signed-off-by: Johannes Marbach <[email protected]>

* Add changelog

* Update content/client-server-api/modules/instant_messaging.md

Co-authored-by: Travis Ralston <[email protected]>

* Update content/client-server-api/modules/instant_messaging.md

Co-authored-by: Travis Ralston <[email protected]>

* Update changelogs/client_server/newsfragments/1870.deprecation

* Rename 1870.deprecation to 1870.removal

---------

Signed-off-by: Johannes Marbach <[email protected]>
Co-authored-by: Travis Ralston <[email protected]>
Co-authored-by: Hubert Chathi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec-bug Something which is in the spec, but is wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the deprecated name attribute on HTML anchor elements Johennes/matrix-spec
2 participants
@HarHarLinks @zecakeh