-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing enum fields for the set_presence parameter #780
Conversation
Can one of the admins verify this patch? |
Signed-off-by: Konstantinos Sideris <[email protected]>
ok to test |
@mujx: are you sure? What makes you believe that other values are valid here? The description only documents |
I thought that the presence parameter would support all the values from the presence endpoints.. If I'm wrong and only one value is allowed why not convert it into a boolean? |
I believe all the values should be allowed. At least, that was my intention when I designed it :) |
@richvdh Any update on this? |
|
@mujx are you able to update this to include descriptions? Given the age, it'd be nice to have this be merged :) |
@mujx Thank you for this PR! I hope you don't mind that I've added the requested descriptions to the PR. Stuff like this is very much part of the "end of August" goal for the spec, which happens to be in just a few short days. It's worth noting that synapse currently does not support I've also merged the latest master into the branch so that the PR can benefit from the new changelog format and build process. |
Thanks @turt2live for finishing the PR. I've forgotten about the PR because I wasn't sure what |
No description provided.