MSC4230: Flag for animated images #4230
Conversation
turt2live
added
proposal
dbkr
changed the title
|
|
||
| ## Proposal | ||
|
|
||
| We add an optional boolean flag, `ia_animated` to the `info` object of image events indicating if |
There was a problem hiding this comment.
To clarify, this field would be allowed in the info on msgtype: m.image and type: m.sticker events?
There was a problem hiding this comment.
I guess just images for now: clarified.
There was a problem hiding this comment.
Any reason not to allow it for stickers?
There was a problem hiding this comment.
I'm not really sure to be honest, which is exactly why I'm leaving it for someone else to propose if they think it's appropriate.
There was a problem hiding this comment.
Given that stickers are ~renamed images, I agree with Sumner that the same should apply to stickers.
We don't have extensible events yet, but MSC3552 goes in the same direction about the images and stickers relation ship.
Co-authored-by: R Midhun Suresh <[email protected]>
|
|
||
| Clients may lie about the flag which would cause unexpected behaviour, for example, an image which | ||
| was not presented might then animate when the user clicks to enlarge it, allowing for 'jump scares' | ||
| or similar. Clients may wish to prevent images from being animated if the flag is set to false. |
There was a problem hiding this comment.
Wouldn't be sensible for an implementation to use this flag only as a hint as to whether it should preload the original, and probe the media regardless of when it was downloaded to confirm the animation? I feel like this MSC is recommending a client behaviour that is a tad too "trusting".
There was a problem hiding this comment.
They could do that if they saw a need to. I've tried to be specific though and call out a distinct case where clients might want to take care over. I don't think it's really the spec's job to enumerate every detail that clients might possibly mess up, although we can certainly give more hints if you think there's something else worth calling out.
|
|
||
| ## Proposal | ||
|
|
||
| We add an optional boolean flag, `is_animated` to the `info` object of `m.image` events indicating if |
There was a problem hiding this comment.
Just to bring it up, we could also give this flag a more general name prefetch_original to express "you might wanna prefetch this", and apply it optionally to any attachment type. A client might assume based on the attachment type, mime type, flag, and other metadata combinations, whether it wants to prefetch, e.g. to play an animated image/gif without delay. Then again I fail to come up with other reasons you might want to hints about prefetching attachments.
There was a problem hiding this comment.
Personally I'm more persuaded by the idea of giving information about the media rather than trying to second guess what the client might want to do.
Co-authored-by: Will Hunt <[email protected]>
Proposes adding a boolean flag to images that indicates whether they're animated.
Impl: element-hq/element-web#28513
Rendered
Disclosure: This is presented wearing my, "Element Employee and Element Web Engineer" hat.