Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC3959: Sliding Sync Extension: Account Data #3959

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Jan 30, 2023

@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:core MSC which is critical to the protocol's success labels Jan 30, 2023
tokens and SHOULD be omitted when the client already has these events.


## Potential issues
Copy link
Contributor

@ShadowJonathan ShadowJonathan Feb 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to make this MSC aware of MSC3391, which adds deletion of account data, and changes/adds the semantics of it.

In the current iteration, it means that receiving {} is interpreted as "deleted" (in a delta response), and that in every initial response, the client should replace all known keys from before with just the keys and data present in the new response.

This semantic change would also potentially interfere with any efforts to deduplicate account data across non-delta-ing sliding sync.

@turt2live turt2live added the matrix-2.0 Required for Matrix 2.0 label Feb 27, 2023
@turt2live turt2live requested review from turt2live and a team February 28, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API kind:core MSC which is critical to the protocol's success matrix-2.0 Required for Matrix 2.0 proposal A matrix spec change proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants