MSC3943: Partial joins to nameless rooms should include heroes' memberships #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
added
proposal
anoadragon453
changed the title
DMRobertson
removed
the
needs-implementation
|
@mscbot fcp merge |
|
Team member @erikjohnston has proposed to merge this. The next step is review by the rest of the tagged people: Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for information about what commands tagged team members can give me. |
mscbot
added
disposition-merge
proposed-final-comment-period
Co-authored-by: Erik Johnston <[email protected]>
turt2live
approved these changes
Jan 16, 2023
|
|
||
| ## Background | ||
|
|
||
| [MSC3706](https://github.com/matrix-org/matrix-spec-proposals/pull/3706) extends the federation `/send_join` endpoint to optionally return a "partial state" response. In this mode of operation, the joining server is given only a _subset_ of the current state[^1] of the room to be joined; the full state is lazily loaded by the joining server. |
There was a problem hiding this comment.
it's not really a problem in this MSC, though for future MSCs please limit lines to ~100 characters.
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
mscbot
added
final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
mscbot
added
finished-final-comment-period
and removed
disposition-merge
final-comment-period
turt2live
added
spec-pr-missing
|
Spec PR: matrix-org/matrix-spec#1425 |
uhoreg
added
spec-pr-in-review
turt2live
added
merged
|
Merged 🎉 |
This was referenced Feb 10, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://github.com/matrix-org/matrix-spec-proposals/pull/3706/files#r1023076655 and matrix-org/synapse#12995 (comment).
Rendered.
Implemented in matrix-org/synapse#14442
FCP tickyboxes