Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC3938: Remove keyId from /keys endpoints #3938

Merged
merged 1 commit into from
Dec 26, 2022
Merged

MSC3938: Remove keyId from /keys endpoints #3938

merged 1 commit into from
Dec 26, 2022

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Nov 22, 2022 •
edited by anoadragon453
Loading

Rendered

matrix-org/synapse#14525 demonstrates Synapse working without this endpoint.

@richvdh richvdh added the proposal A matrix spec change proposal label Nov 22, 2022
@turt2live turt2live added s2s Server-to-Server API (federation) kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Nov 22, 2022
@richvdh richvdh mentioned this pull request Nov 22, 2022
Merged
@richvdh

This comment was marked as duplicate.

Sign in to view
@richvdh richvdh removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Dec 13, 2022
@richvdh
Copy link
Member Author

richvdh commented Dec 13, 2022

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Dec 13, 2022 •
edited by dbkr
Loading

Team member @richvdh has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Dec 13, 2022
@mscbot
Copy link
Collaborator

mscbot commented Dec 21, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Dec 21, 2022
@mscbot
Copy link
Collaborator

mscbot commented Dec 26, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Dec 26, 2022
@turt2live turt2live merged commit 006ca6a into main Dec 26, 2022
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Dec 26, 2022
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Dec 26, 2022
@uhoreg
Copy link
Member

uhoreg commented Dec 26, 2022

Spec PR is matrix-org/matrix-spec#1350

@turt2live
Copy link
Member

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jan 3, 2023
This was referenced Jan 3, 2023
Closed
Closed
Merged
@richvdh richvdh deleted the rav/proposal/kill_key_id branch January 3, 2023 12:25
@clokep clokep mentioned this pull request Feb 17, 2023
Closed
8 tasks
clokep
clokep reviewed May 1, 2023
View reviewed changes
proposals/3938-remove-keyid-from-keys-endpoints.md
Comment on lines +27 to +29
This is a breaking change: some servers (such as Synapse, until [very
recently](https://github.com/matrix-org/synapse/pull/14525)) may include the
`{keyId}` in outgoing requests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked a bit about this in the synapse issue for how to support Matrix v1.6: matrix-org/synapse#15089 (comment)

clokep
clokep reviewed May 1, 2023
View reviewed changes
proposals/3938-remove-keyid-from-keys-endpoints.md
Comment on lines +3 to +7
The `keyId` path parameter on
[`GET /_matrix/key/v2/server/{keyId}`](https://spec.matrix.org/v1.5/server-server-api/#get_matrixkeyv2serverkeyid)
and [`GET /_matrix/key/v2/query/{serverName}/{keyId}`](https://spec.matrix.org/v1.5/server-server-api/#get_matrixkeyv2queryservernamekeyid)
has been deprecated since before the Matrix spec was formally versioned
([pull request](https://github.com/matrix-org/matrix-spec-proposals/pull/1423)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't explicitly called out, but I assume POST /_matrix/key/v2/query is unchanged by this MSC?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That does not take a keyId parameter.

@S7evinK S7evinK mentioned this pull request Oct 2, 2023
Open
11 tasks
@matrixbot matrixbot mentioned this pull request Nov 1, 2024
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live left review comments

@clokep clokep clokep left review comments

Assignees
No one assigned
Labels
kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal s2s Server-to-Server API (federation)
Projects
Spec Core Team Backlog
Status: Done to some definition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@richvdh @mscbot @uhoreg @turt2live @clokep