-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC3824: OIDC aware clients #3824
Open
hughns
wants to merge
17
commits into
main
Choose a base branch
from
hughns/sso-redirect-action
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
138f00b
Add an optional query parameter to SSO redirect
hughns 5cba2ff
MSC3824
hughns ca78691
Update proposals/3824-sso-redirect-action.md
hughns 3a67748
Add supported actions per auth type
hughns 1b10fa9
Add GET /_matrix/client/v3/register alternative
hughns 0cd72c6
Rework proposal to be about OIDC aware clients
hughns 8adb0ff
Rename proposal file
hughns e98fc13
Use _ formatted flag name
hughns ccf6b1b
Fixes to Homeserver and Client requirements list
hughns 13e7f44
RECOMMENDED: label SSO button as "Continue"
hughns 262b395
Use unstable prefix for action query param
hughns c2ab31f
Reference to MSC3861
hughns 5bee189
Update proposals/3824-oidc-aware-clients.md
hughns 0eea9ae
Style
hughns eec93e1
Reorganise requiremetns
hughns 54b3e85
Add 3pid and session management requirements
hughns a7ecdfd
Update account management/web UI link parameters for consistency with…
hughns File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Reorganise requiremetns
- Loading branch information
commit eec93e198ad0bf0ca35d158800af8ed71ba64b6a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,21 +54,27 @@ n.b. we don't need to add this to the [Login Fallback](https://spec.matrix.org/v | |
|
||
### Definition of OIDC aware | ||
|
||
For a client to be considered *OIDC aware* it would: | ||
For a client to be considered fully *OIDC aware* it **must**: | ||
|
||
- support the `m.login.sso` auth flow | ||
- where a `delegated_oidc_compatibility` value of `true` is present on an `m.login.sso` then *only* offer that auth flow to the user | ||
- append `action=login` and `action=register` parameters to the SSO redirect URLs | ||
- link users to manage their account at the OP web UI given by [MSC2965](https://github.com/matrix-org/matrix-spec-proposals/pull/2965) instead of native UI | ||
- RECOMMENDED: label the SSO button as "Continue" | ||
|
||
For an OIDC enabled homeserver to provide support for *OIDC aware* clients it would: | ||
Optionally, an *OIDC aware* client **could**: | ||
|
||
- label the SSO button as "Continue" | ||
|
||
For an OIDC enabled homeserver to provide support for *OIDC aware* clients it **must**: | ||
|
||
- support OIDC delegation as per [MSC2964](https://github.com/matrix-org/matrix-spec-proposals/pull/2964) and others | ||
- provide a compatibility layer for `m.login.password` and `m.login.sso` that wraps on to OIDC | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it defined how |
||
- indicate that the `m.login.sso` is preferred by setting `delegated_oidc_compatibility` to `true` | ||
- make use of the `action` param on the SSO redirect endpoints | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make use of it to do what? |
||
- RECOMMENDED: advertise the account management UI in accordance with [MSC2965](https://github.com/matrix-org/matrix-spec-proposals/pull/2965) | ||
|
||
Additionally, the homeserver **should**: | ||
|
||
- advertise the account management UI in accordance with [MSC2965](https://github.com/matrix-org/matrix-spec-proposals/pull/2965) | ||
|
||
## Potential issues | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious what the rationale behind suggesting copy for the client's UI is here. Would the SSO button not redirect through a browser as before, regardless of whether OIDC is in play or not?