Use a separate receiptType for hidden read receipts
#3750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <[email protected]>
|
Generally, things like this should be handled as a separate MSC, rather than a change to an existing MSC. |
Yes, I am aware though I'd prefer to not make another MSC as T seems to agree with changing the method of how this works in theirs, though I can't really push to the branch, so I made a PR... Some context: #2285 (comment) |
|
(yea, for context: I effectively asked for this :p ) |
|
Note that merging this could be a bit odd though since MSC2285 has already had FCP called on it (and has some ticks). We ran into this a bit with one of the spaces MSCs where it changed fairly dramatically after some approvals (and unfortunately caused some bugs to slip through). Perhaps after merging the ticks should be reset? (Also +1 to the change btw. 👍 ) |
|
FCP cancelled. |
turt2live
approved these changes
Mar 3, 2022
turt2live
added a commit
that referenced
this pull request
Jul 17, 2022
* What if we let people hide their read receipts? * Add unstable prefix * Update proposals/2285-hidden-read-receipts.md Co-authored-by: Šimon Brandner <[email protected]> * Use a separate `receiptType` for hidden read receipts (#3750) * Update the way MSC2285 works Signed-off-by: Šimon Brandner <[email protected]> * Update proposals/2285-hidden-read-receipts.md Co-authored-by: Travis Ralston <[email protected]> * Clarify notification behaviour and other things Co-authored-by: Patrick Cloke <[email protected]> * Mention adding `m.fully_read` to `/receipt` * Rename MSC to `Private read receipts` Signed-off-by: Šimon Brandner <[email protected]> * Apply suggestions from review Co-authored-by: Richard van der Hoff <[email protected]> * Apply suggestions from review Co-authored-by: Richard van der Hoff <[email protected]> * Remove trailing comma Co-authored-by: Richard van der Hoff <[email protected]> * Apply suggestions from review Signed-off-by: Šimon Brandner <[email protected]> * Apply suggestions from review Signed-off-by: Šimon Brandner <[email protected]> * `r0` -> `v3` Signed-off-by: Šimon Brandner <[email protected]> * Describe how to determine server support while stable Signed-off-by: Šimon Brandner <[email protected]> * Be more precise about the failure mode Signed-off-by: Šimon Brandner <[email protected]> * Improve wording Co-authored-by: Richard van der Hoff <[email protected]> * Improve wording Co-authored-by: Richard van der Hoff <[email protected]> * Improve wording Signed-off-by: Šimon Brandner <[email protected]> * Be more explicit Signed-off-by: Šimon Brandner <[email protected]> * Be more explicit around server support Signed-off-by: Šimon Brandner <[email protected]> * Simplify text Signed-off-by: Šimon Brandner <[email protected]> * Be more explicit about detecting server support Signed-off-by: Šimon Brandner <[email protected]> * Add note about consistency Signed-off-by: Šimon Brandner <[email protected]> * Clarify how exactly to detect support * Try to fix clarity around precedence * Be clearer about alternatives Signed-off-by: Šimon Brandner <[email protected]> * Add sentence about `/receipt` federation Signed-off-by: Šimon Brandner <[email protected]> * Be more explicit about adding `m.read.private` to `/receipt` Signed-off-by: Šimon Brandner <[email protected]> * Fix wrong RR type Co-authored-by: Kévin Commaille <[email protected]> Co-authored-by: Šimon Brandner <[email protected]> Co-authored-by: Patrick Cloke <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]> Co-authored-by: Kévin Commaille <[email protected]>
turt2live
added a commit
that referenced
this pull request
Jul 18, 2022
* What if we let people hide their read receipts? * Add unstable prefix * Update proposals/2285-hidden-read-receipts.md Co-authored-by: Šimon Brandner <[email protected]> * Use a separate `receiptType` for hidden read receipts (#3750) * Update the way MSC2285 works Signed-off-by: Šimon Brandner <[email protected]> * Update proposals/2285-hidden-read-receipts.md Co-authored-by: Travis Ralston <[email protected]> * Clarify notification behaviour and other things Co-authored-by: Patrick Cloke <[email protected]> * Mention adding `m.fully_read` to `/receipt` * Rename MSC to `Private read receipts` Signed-off-by: Šimon Brandner <[email protected]> * Apply suggestions from review Co-authored-by: Richard van der Hoff <[email protected]> * Apply suggestions from review Co-authored-by: Richard van der Hoff <[email protected]> * Remove trailing comma Co-authored-by: Richard van der Hoff <[email protected]> * Apply suggestions from review Signed-off-by: Šimon Brandner <[email protected]> * Apply suggestions from review Signed-off-by: Šimon Brandner <[email protected]> * `r0` -> `v3` Signed-off-by: Šimon Brandner <[email protected]> * Describe how to determine server support while stable Signed-off-by: Šimon Brandner <[email protected]> * Be more precise about the failure mode Signed-off-by: Šimon Brandner <[email protected]> * Improve wording Co-authored-by: Richard van der Hoff <[email protected]> * Improve wording Co-authored-by: Richard van der Hoff <[email protected]> * Improve wording Signed-off-by: Šimon Brandner <[email protected]> * Be more explicit Signed-off-by: Šimon Brandner <[email protected]> * Be more explicit around server support Signed-off-by: Šimon Brandner <[email protected]> * Simplify text Signed-off-by: Šimon Brandner <[email protected]> * Be more explicit about detecting server support Signed-off-by: Šimon Brandner <[email protected]> * Add note about consistency Signed-off-by: Šimon Brandner <[email protected]> * Clarify how exactly to detect support * Try to fix clarity around precedence * Be clearer about alternatives Signed-off-by: Šimon Brandner <[email protected]> * Add sentence about `/receipt` federation Signed-off-by: Šimon Brandner <[email protected]> * Be more explicit about adding `m.read.private` to `/receipt` Signed-off-by: Šimon Brandner <[email protected]> * Fix wrong RR type Co-authored-by: Kévin Commaille <[email protected]> Co-authored-by: Šimon Brandner <[email protected]> Co-authored-by: Patrick Cloke <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]> Co-authored-by: Kévin Commaille <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.