Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe matrix: URI scheme #3608

Merged
merged 4 commits into from
Dec 31, 2021
Merged

Describe matrix: URI scheme #3608

merged 4 commits into from
Dec 31, 2021

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Dec 30, 2021

Replaces #3168
MSC: #2312

Updated for modern times.

Changelog entry compatible with #3609

Preview: https://pr3608--matrix-org-previews.netlify.app

@turt2live turt2live requested a review from a team December 30, 2021 01:09
content/appendices.md Show resolved Hide resolved

Currently, the `authority` and `fragment` are unused by this specification,
though are reserved for future use. Matrix does not have a central authority which
could reasonably fill the `authority` role. `nonid-segment` in the schema is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some explanation of what the nonid-segment could possibly be(come) would help. I'm not getting a sense of understanding what it is while reading this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MSC doesn't appear to have much more information, sorry.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really define it beyond "a segment to specify a resource that is not supposed to have an id", which is pretty tautological and not any clearer. The idea was that some resources don't need an id but could benefit from having a URI - as a contrived example, some kind of a cloak-room/homepage for a space.

In any case, this PR is meant for purely technical purposes so not a good place to introduce new wording; and as Travis said, the original MSC doesn't have anything to build on, anyway.

content/appendices.md Outdated Show resolved Hide resolved
content/appendices.md Show resolved Hide resolved
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@turt2live turt2live merged commit 592cbd5 into main Dec 31, 2021
@turt2live turt2live deleted the travis/spec/matrix-uri-2312 branch December 31, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants