Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifications to pagination parameters for various APIs #3353

Merged
merged 4 commits into from
Aug 25, 2021

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Aug 19, 2021

I believe these are just clarifications of existing parameters, though some of them are verging on bugfixes.

Fixes: #2420
Fixes: #3019.

@richvdh richvdh requested a review from a team August 19, 2021 18:11
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks fine - thanks for taking a stab at this!

@richvdh richvdh requested a review from turt2live August 23, 2021 18:06
@turt2live turt2live removed their request for review August 23, 2021 21:33
@richvdh
Copy link
Member Author

richvdh commented Aug 24, 2021

@turt2live I've added some extra words - PTAL?

@richvdh richvdh requested a review from turt2live August 24, 2021 08:42
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm either way

data/api/client-server/message_pagination.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nitpick] /messages "dir" parameter is ambiguous Doc on /messages is unclear/untrue
2 participants