Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the buildkite pipeline to build a release on v* tags #3295

Closed
wants to merge 4 commits into from

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Jul 26, 2021

This PR updates the buildkite pipeline to build and host an artefact for a spec release whenever a git tag matching v* is pushed.

The artefact will then be consumed by an instance of buildkite-webhook-listener which will download and extract the contents for hosting.

This follows the steps laid out in the plan for the new spec release infrastructure.

Note that I also refactored some of the hugo environment setup steps here.

Requires #3310.

@anoadragon453 anoadragon453 force-pushed the anoa/spec_release_infra branch 23 times, most recently from c645e3e to ded4b71 Compare July 27, 2021 17:57
@anoadragon453 anoadragon453 force-pushed the anoa/spec_release_infra branch 2 times, most recently from 8c66108 to 2cecc49 Compare August 3, 2021 16:29
@anoadragon453 anoadragon453 marked this pull request as ready for review August 3, 2021 18:33
@anoadragon453 anoadragon453 force-pushed the anoa/spec_release_infra branch 2 times, most recently from 5c2c683 to a93aca9 Compare August 3, 2021 18:33
@anoadragon453 anoadragon453 requested a review from a team August 3, 2021 18:35
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks generally plausible but I'm withholding judgement pending #3310.

.buildkite/pipeline.yaml Show resolved Hide resolved
@anoadragon453 anoadragon453 force-pushed the anoa/spec_release_infra branch from 5d82bae to c6459b1 Compare August 10, 2021 17:07
@anoadragon453
Copy link
Member Author

This PR has been rebased on top of the current master branch with #3310 now merged in.

@anoadragon453 anoadragon453 requested a review from richvdh August 10, 2021 17:16
Comment on lines +10 to +11
# Pull current proposal information
npm run get-proposals
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it right that this is part of the release?

.buildkite/pipeline.yaml Show resolved Hide resolved
image: alpine
mount-buildkite-agent: false
propogate-environment: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, if this is required, you better spell propagate correctly. I suspect it's not required?

fi

# Modify the build config to specify a stable release
sed -i.bak -e 's/status = "unstable"/status = "stable"/' config.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than overwrite config.toml (and have to replace it later, with the possible danger of not doing so if the script exits early, could you write the modified config to a temp file and give hugo a --config option?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, given hugo lets you specify multiple config files, maybe you don't need to copy the whole thing, and can just generate a second config file which overrides/sets the options you need?

scripts/prepare-spec-release.sh Show resolved Hide resolved
.buildkite/pipeline.yaml Outdated Show resolved Hide resolved
scripts/prepare-spec-release.sh Show resolved Hide resolved
Co-authored-by: Richard van der Hoff <[email protected]>
@anoadragon453
Copy link
Member Author

This will soon be superseded by a GitHub Actions pipeline (cc @turt2live, in case anything here is useful to reference).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants