-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the buildkite pipeline to build a release on v* tags #3295
Conversation
c645e3e
to
ded4b71
Compare
8c66108
to
2cecc49
Compare
5c2c683
to
a93aca9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks generally plausible but I'm withholding judgement pending #3310.
5d82bae
to
c6459b1
Compare
This PR has been rebased on top of the current |
# Pull current proposal information | ||
npm run get-proposals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it right that this is part of the release?
image: alpine | ||
mount-buildkite-agent: false | ||
propogate-environment: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, if this is required, you better spell propagate
correctly. I suspect it's not required?
fi | ||
|
||
# Modify the build config to specify a stable release | ||
sed -i.bak -e 's/status = "unstable"/status = "stable"/' config.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather than overwrite config.toml
(and have to replace it later, with the possible danger of not doing so if the script exits early, could you write the modified config to a temp file and give hugo a --config
option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, given hugo lets you specify multiple config files, maybe you don't need to copy the whole thing, and can just generate a second config file which overrides/sets the options you need?
Co-authored-by: Richard van der Hoff <[email protected]>
This will soon be superseded by a GitHub Actions pipeline (cc @turt2live, in case anything here is useful to reference). |
This PR updates the buildkite pipeline to build and host an artefact for a spec release whenever a git tag matching
v*
is pushed.The artefact will then be consumed by an instance of buildkite-webhook-listener which will download and extract the contents for hosting.
This follows the steps laid out in the plan for the new spec release infrastructure.
Note that I also refactored some of the hugo environment setup steps here.
Requires
#3310.