Change space's valid order range to 0x7E
#3195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x7F is DEL, which is clearly not intended by the proposal text.
|
Hah, didn't notice when implementing in EW |
|
Element Web fixed by matrix-org/matrix-react-sdk#6042 |
richvdh
approved these changes
May 16, 2021
richvdh
pushed a commit
that referenced
this pull request
Aug 23, 2021
Change space's valid `order` range to 0x7E
richvdh
pushed a commit
that referenced
this pull request
Aug 27, 2021
Change space's valid `order` range to 0x7E
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0x7F is DEL, which is clearly not intended by the proposal text.