Change id -> event_id and include push section
#306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t's the Matrix event ID of the message. Correct the spec for badge count pushes which omit fields previously described as mandatory. Add more detail about when to use event_id to suppress dupes. Also add the push gateway doc so it's actually included in the spec.
| alerted in some way. It is therefore necessary to perform duplicate | ||
| suppression for such notifications using the `event_id` field to avoid | ||
| retries of this HTTP API causing duplicate alerts. The operation of | ||
| updating counts of unread notifications should be and therefore do not |
|
I think |
|
By the way, could you try to give your commit messages short summary lines ? |
They are actually within the notification object rather than the top level object. Add titles to objects so it works.
|
Noticed some other problems too. ptal. |
|
lgtm now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idin the push gateway poke to beevent_idand spec that it's the Matrix event ID of the message. This is much more useful since it will allow a client to fetch just the event it's being notified about, or know when this event comes down its event stream.