-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC2964: Usage of OAuth 2.0 authorization code grant and refresh token grant #2964
Open
sandhose
wants to merge
32
commits into
matrix-org:main
Choose a base branch
from
sandhose:msc/sandhose/oauth2-profile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+268
−0
Open
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
2af8b49
OAuth 2.0 profile MSC
sandhose 5962618
Refer to OP rather than AS to avoid clash with Application Service
hughns 38c97a5
Title update and intro about architectural change
hughns e12ee77
Add section on endpoints that would now be outside of scope and so re…
hughns 20d865d
Spelling
hughns 261e3b0
Section on proposed endpoints that would no longer be relevant
hughns 38bb557
Consistency with MSC3861 and cleanup
hughns 45d510b
Standardise terminology on OpenID Provider = OP
hughns d114f82
Update proposals/2964-oauth2-profile.md
hughns 8fc3ea1
Notes on QR and browserless
hughns 029e1e5
OpenID id_token endpoint is still needed
hughns 0802d8f
Notes about confusion with existing OIDC and OpenID capabilities
hughns 20ee4a3
Additional endpoints to be removed
hughns 6e387d8
Add 3pid endpoints that would be removed
hughns 4a2ed74
Changes to GET /account/3pid
hughns 40048da
Alternative proposal for 3PID handling
hughns f0e319a
Add section on removing UIA
hughns 55215c1
Refer to UIA as API
hughns 21fee1c
We now have proposal for 3PID and guest access
hughns 2c0625d
Logout semantics
hughns 24e0290
Remove TBDs that are done
hughns d145fd2
Merge branch 'msc/sandhose/oauth2-profile' of https://github.com/sand…
hughns acfa845
More done items
hughns fa506ff
Remove dependency loop
hughns 378348e
Merge branch 'matrix-org:main' into msc/sandhose/oauth2-profile
sandhose c859c0b
Rework proposal to only cover the authorization code flow
sandhose c1c8312
Fix a bunch of todos
sandhose 05748a2
Fix typos
sandhose 1034122
Fix the response_mode being an authorization request parameter
sandhose 4830d47
Apply suggestions from code review
sandhose f84428f
Remove unused images
sandhose c57be5e
Expand the security considerations section
sandhose File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Fix typos
commit 05748a27015ec126e9ed2d153c16078c3c64dab6
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what exactly is meant by a "public client"? I can guess, but I think we should maybe be more explicit.