Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make event's title fields UpperCamelCase and distinguish /sync ones #2647

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Make event's title fields UpperCamelCase and distinguish /sync ones #2647

merged 1 commit into from
Jun 19, 2020

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Jun 19, 2020

Signed-off-by: Jonas Platte [email protected]

@turt2live turt2live requested a review from a team June 19, 2020 18:44
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why I requested review, this is pretty tiny.

Would be good to have a changelog entry along the lines of "Improve consistency in naming of schemas."

@turt2live
Copy link
Member

ah, the other thing is signoff: can we get a comment here with something like the following please?

Signed-off-by: Your Name <[email protected]>

@jplatte
Copy link
Contributor Author

jplatte commented Jun 19, 2020

Signoff added, squashed.

@turt2live turt2live merged commit 465ed38 into matrix-org:master Jun 19, 2020
@jplatte jplatte deleted the event-titles branch June 19, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants