Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2582: Remove mimetype from EncryptedFile object #2582

Merged
merged 3 commits into from
Aug 30, 2021
Merged

MSC2582: Remove mimetype from EncryptedFile object #2582

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01f4b78
add proposal
Sorunome May 26, 2020
e0f1b09
Update proposals/2582-remove-mimetype-from-encrypted-file.md
Sorunome Aug 28, 2021
46cfac7
Update proposals/2582-remove-mimetype-from-encrypted-file.md
Sorunome Aug 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions proposals/2582-remove-mimetype-from-encrypted-file.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Remove `mimetype` from `EncryptedFile` object


## Proposal
The example in the spec currently lists `mimetype` in the [examples for `EncryptedFile`](https://matrix.org/docs/spec/client_server/r0.6.1#extensions-to-m-message-msgtypes) but not in
the object definition. As that is duplicate information of the `info` block of file events, the
uhoreg marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note that the EncryptedFile appears twice in the examples: in the file property (top-level) and it info.thumbnail_file. mimetype is given in both places.

mimetype should just be removed alltogether.


## Potential issues
Some clients might depend on this. However, as of August 2021, all known clients have
been confirmed to not use this.