-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec MSC2290: 3PID binding split #2328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly looks fine
those that it trusts. | ||
the |/register/email/requestToken|_ endpoint. The homeserver should validate | ||
the email itself, either by sending a validation email itself or by using | ||
a service it has control over. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a service it has control over. | |
a service it trusts. |
? (and elswhere) given that people can use vector.im for validation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MSC specifically says "control" and explicitly discourages trust.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks plausible
Spec PR for MSC2290
This is the last of the identity spec PRs. See #2253 for details.
There are no known deviations from the MSC and implementation in this PR.